Remove inline eslint globals in configs#1129
Open
janbrasna wants to merge 4 commits intomozilla:mainfrom
Open
Conversation
janbrasna
commented
Feb 28, 2026
Contributor
Author
janbrasna
left a comment
janbrasna
left a comment
There was a problem hiding this comment.
The CI runs that twice:
- /actions/runs/22524118040/job/65253378571#step:5:33
- /actions/runs/22524118040/job/65253378571#step:6:10
and is apparently happy.
Comment on lines
-7
to
8
| /* eslint-env node, commonjs, es2017 */ | ||
|
|
||
| const CopyPlugin = require('copy-webpack-plugin'); | ||
| const path = require('path'); |
Contributor
Author
There was a problem hiding this comment.
Worth noting the new globals are defined slightly differently:
Lines 124 to 132 in d20837b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
These are defined in the new config since #935 and should no longer use the old format.
I have documented this change in the design system.I have recorded this change inCHANGELOG.md.Issue
#1121
Testing
CI pass on v9 should be enough to verify v10 compatibility of these removals.